chore(gmpctl): remove install of bingo deps - #1963
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the execution of the presubmit script from the release-lib::manifests_regen function in ops/gmpctl/lib.sh. Feedback indicates that this change completely disables manifest regeneration, and a suggestion has been provided to retain the invocation of hack/presubmit.sh without the obsolete bingo variable swap.
I am having trouble creating individual review comments. Click here to see my feedback.
ops/gmpctl/lib.sh (450-455)
By removing the execution of hack/presubmit.sh manifests, the release-lib::manifests_regen function no longer actually regenerates the manifests. It only prints a success message without performing any work.
Since hack/presubmit.sh now uses go tool with tools/go.mod to run helm, yq, and addlicense, we no longer need the bingo variable swap, but we still must invoke the presubmit script to perform the regeneration.
bash "${dir}/hack/presubmit.sh" manifests
afd8d74 to
06140d3
Compare
06140d3 to
1ca1363
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds gmpctl to the list of policies in .conform.yaml and simplifies the manifest regeneration process in ops/gmpctl/lib.sh by removing manual tool installations (helm, addlicense, yq) and a hacky bingo variable swap, delegating the execution directly to the presubmit script. There are no review comments, and I have no feedback to provide.
| echo "#!/bin/bash" >"${dir}/.bingo/variables.env" # Clean the file. | ||
| YQ="$(which yq)" HELM="$(which helm)" ADDLICENSE="$(which addlicense)" bash "${dir}/hack/presubmit.sh" manifests | ||
| cp "${dir}/.bingo/variables.env.bak" "${dir}/.bingo/variables.env" | ||
| bash "${dir}/hack/presubmit.sh" manifests |
There was a problem hiding this comment.
Unfortunately this won't work across all versions - it only makes it work for 0.19/main.
This could make it work for now: https://github.com/GoogleCloudPlatform/prometheus-engine/pull/1938/changes#r3441808186
2 participants
#1861 removed Bingo. This removes the dependency on Bingo from gmpctl.